Fix OllamaContainer's commitToImage (#788)

testcontainers · Jul 1, 2024 · 7f39fba · 7f39fba
1 parent 4059231
commit 7f39fba
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/modules/ollama/src/ollama-container.test.ts b/packages/modules/ollama/src/ollama-container.test.ts
@@ -29,6 +29,7 @@ describe("OllamaContainer", () => {
     // commitToImage {
     await container.commitToImage(newImageName);
     // }
+    await container.stop();
 
     // substitute {
     const newContainer = await new OllamaContainer(newImageName).start();
@@ -37,7 +38,6 @@ describe("OllamaContainer", () => {
     expect(response2.status).toEqual(200);
     const body2 = await response2.json();
     expect(body2.models[0].name).toContain("all-minilm");
-    await container.stop();
     await newContainer.stop();
   });
 });
diff --git a/packages/modules/ollama/src/ollama-container.ts b/packages/modules/ollama/src/ollama-container.ts
@@ -49,6 +49,8 @@ export class StartedOllamaContainer extends AbstractStartedContainer {
   public async commitToImage(imageName: string): Promise<NodeJS.ReadableStream> {
     const client = await getContainerRuntimeClient();
     const dockerode = client.container.dockerode;
-    return dockerode.getContainer(this.getId()).commit({ repo: imageName });
+    return dockerode
+      .getContainer(this.getId())
+      .commit({ repo: imageName, Labels: { "org.testcontainers.session-id": "" } });
   }
 }