Add support for Docker credential providers which do not implement list command

[glebbash]

Fixes #739

[netlify]

✅ Deploy Preview for testcontainers-node ready!

Name	Link
🔨 Latest commit	2ed4764
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-node/deploys/6792de19d226790008fab9ec
😎 Deploy Preview	https://deploy-preview-902--testcontainers-node.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[cristianrgreco]

Hi @glebbash, you've added a test should not throw when list credentials command is not implemented, but it's not clear why not throwing when listing credentials is useful or required. Instead please add a test verifying an actual output, e.g a file containing GCR credentials now works.

[glebbash]

I am not sure what you mean about a file with GCR credentials and what the expected output should be. As for reasons why this is required I think it's pretty clear - if command is not implemented it should just use defaults.

Adding a link to the issue in a comment before the condition could make it clearer but I just wanted to make the minimum amount of changes to support docker-credential-gcr.

[cristianrgreco]

I mean, this PR supposedly fixes the resolution of GCR credentials, could you show that? A test showing that something returns an empty object doesn't show that

[glebbash]

This PR does not fix resolution of GCR credentials. What it does is make testcontainers usable for whoever happens to be using docker-credential-gcr. I really don't care about credentials and I don't want to dig into this repo to figure out all the details.

I was patching the lib's compiled JS source to make it not throw the An error occurred listing credentials error. And here I copied the changes to the TypeScript source.

I don't know if this supports private GCR registries or whatever, the only thing I know is that it fixes the issue described in #739 which has 5 +1s so I don't think that it's just my setup that is affected.

[glebbash]

@cristianrgreco if you have a better test in mind feel free to update the PR or fix this issue in different PR.

[cristianrgreco]

I think it's my misunderstanding TBH. The PR said it added support for docker-credential-gcr so I assumed it would support resolving GCR credentials. I didn't realise that supporting docker-credential-gcr actually involves just not throwing when running the list command 😄

I really don't care about credentials and I don't want to dig into this repo to figure out all the details.

Thought this was a bit rude TBH. I work on this project in my free time. If I propose a suggestion and the response is effectively "I don't care and I can't be asked to find out", it doesn't particularly motivate me to work on it.

the only thing I know is that it fixes the issue described in #739 which has 5 +1s so I don't think that it's just my setup that is affected

This project has a lot of moving parts and 2M downloads/month. Five +1s on a year old issue isn't exactly concerning, but thanks for the contribution.

if you have a better test in mind feel free to update the PR or fix this issue in different PR.

Thanks for the advice 😅

[glebbash]

Definitely did not intend to be rude. Was just getting trying to describe the situation in multiple ways :)

And thanks for your work on the lib 👍