-
Notifications
You must be signed in to change notification settings - Fork 297
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(core): Improve typing for common container usage scenarios (#523)
Improves type hints for type checking in a common use cases: ```python with MySqlContainer("mysql:8").with_env("some", "value") as mysql: url = mysql.get_connection_url() # get_connection_url would previously be an unknown member here ``` And, also improved type hinting for the custom `DockerClient`'s `run` command, where the linter no longer reports an error due to missing parameter types: ```python DockerClient.run("nginx") # Previously this would report "Argument missing for parameter "image" ```
- Loading branch information
Showing
2 changed files
with
28 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters