Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose module with V2 support #400

Closed
wants to merge 6 commits into from

Conversation

carlosemart
Copy link

Co-authored-by: @jhnnsrs and @psschwei

Fixes #306

I recover the compose module and the work do it on #362, fixing a bug in the loading of the docker-compose files that caused the tests to never finish.

I have also removed the dependency of the docker-compose module, delegating the calls to the client installed in the system.

@alexanderankin
Copy link
Member

linking also #358

Copy link
Member

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i approve this, do tests run?

@carlosemart
Copy link
Author

@alexanderankin, I don't know who should approve the pr, but there should be an "Approve and run" button like this one:
imagen

@carlosemart
Copy link
Author

I rebase main branch with poetry changes

@totallyzen
Copy link
Collaborator

totallyzen commented Feb 29, 2024

hey @carlosemart sorry for the disappiontment, we've decided to rewrite the compose from the ground up, because it isn't just a matter of subprocess.run(["docker", "compose"]) but fixing the underlying mechanism with fetching ports and more. docker compose ps --format json is a thing now so decided to make it much more strongly typed.

see #426

of course, your review is welcome on the PR, however I would like to avoid duplicating the effort on multiple PRs.
We're also collating a bunch of fixes for compose onto that PR!

@carlosemart
Copy link
Author

No problem @totallyzen, I made the pr to be continuist with the 3.x versions but it is true that taking advantage of the change of major version the deepest changes have much more sense.

@carlosemart
Copy link
Author

Duplicate with #426

@carlosemart carlosemart closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring the docker-compose executable path
3 participants