Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oracle): Remove unmaintained Oracle community module #513

Closed
wants to merge 2 commits into from

Conversation

santi
Copy link
Collaborator

@santi santi commented Mar 30, 2024

There are multiple problems with the current support for the Oracle module.

  • The author of the image seems to no longer maintain it
  • The original image (without the -r2 suffix was DMCA'd by Oracle from DockerHub. Not sure if the new one is actually compliant or if it has just gone under the radar.
  • The image uses an old build of Ubuntu 18.04 (which reached EOL in May 2023)
  • There is really nothing special in the setup and running of the image, which would not qualify for a community module currently (no wait strategy, almost no custom setup). An example code snippet would suffice in this case.
  • It does not support running on Apple Silicone, and requires client libraries to be installed to run in general.

Therefore, I suggest that we remove this module.

@santi santi changed the title remove!: Remove unsupported Oracle community module remove!: Remove unmaintained Oracle community module Mar 30, 2024
@santi santi changed the title remove!: Remove unmaintained Oracle community module fix!: Remove unmaintained Oracle community module Mar 30, 2024
@santi santi changed the title fix!: Remove unmaintained Oracle community module fix(oracle): Remove unmaintained Oracle community module Mar 30, 2024
@santi
Copy link
Collaborator Author

santi commented Mar 30, 2024

Just discovered this one: #363 Will check out it and similar ideas before moving forward with this one.

@santi santi marked this pull request as draft March 30, 2024 20:27
Copy link
Collaborator

@totallyzen totallyzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general concept, if #363 doesn't work out, you've got my approval to remove. It's better to keep a healthy project than broken features.

This also comes back to "what level of guarantee do we have for community modules?" with this being a breaking change (or not) - either way, I approve the concept, but may want to wait with merging it for the correct semver identification

🙏

Copy link
Member

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a PR to update oracle to mr. venzl's version, if we merge this, it gets harder to rebase that PR, please consider not merging, as i do have a plan for this module.

@alexanderankin
Copy link
Member

sorry, just saw the other newly opened PR, catching up still...

@alexanderankin
Copy link
Member

not necessary after #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants