refactor: make config monkeypatchable #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what if we gave you the red carpet treatment and actually made an API for this, like https://github.com/testcontainers/testcontainers-python/compare/editable_config?expand=1 |
alexanderankin
added a commit
that referenced
this pull request
Apr 8, 2024
see #531: I am using testcontainers within a library that provides some pytest-fixtures. In order for this to work I have change some settings. As I can not guarantee that that my lib is imported before testcontainers I need to monkeypatch the settings. This is much easier if I only need to monkeypatch the config file and not all modules that use configurations. I would argue that for a potential library as this, this is a better design. Also one can easier see that the given UPERCASE variable is not a constant but rather a setting. Co-authored-by: Carli* Freudenberg <[email protected]>
|
thanks for the idea - i gave you credit in my merge commit in #532, going to close this for now |
mloesch
pushed a commit
to mloesch/testcontainers-python
that referenced
this pull request
Apr 8, 2024
…ners#532) see testcontainers#531: I am using testcontainers within a library that provides some pytest-fixtures. In order for this to work I have change some settings. As I can not guarantee that that my lib is imported before testcontainers I need to monkeypatch the settings. This is much easier if I only need to monkeypatch the config file and not all modules that use configurations. I would argue that for a potential library as this, this is a better design. Also one can easier see that the given UPERCASE variable is not a constant but rather a setting. Co-authored-by: Carli* Freudenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using testcontainers within a library that provides some pytest-fixtures.
In order for this to work I have change some settings.
As I can not guarantee that that my lib is imported before testcontainers I need to monkeypatch the settings.
This is much easier if I only need to monkeypatch the config file and not all modules that use configurations.
I would argue that for a potential library as this, this is a better design.
Also one can easier see that the given UPERCASE variable is not a constant but rather a setting.