fix: added types to exec & tc_properties_get_tc_host #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
approved these changes
Apr 29, 2024
|
@kiview could you please approve the workflows to run? |
|
We'll take a look |
|
yep so we support python 3.9 for now so cant use the pipe syntax for ill leave this open in case you want to replace with |
Dandiggas
force-pushed
the
docker-container-exec-type
branch
from
b66a469 to
a43d3b5
Compare
|
@alexanderankin Now supports python 3.9, please review when possible |
alexanderankin
changed the title
|
thank you for the contribution! if you are interested in improving typing in this library are other types that I have started but did not feel confident enough to merge #504 |
alexanderankin
pushed a commit
that referenced
this pull request
May 25, 2024
🤖 I have created a release *beep* *boop* --- ## [4.5.0](testcontainers-v4.4.1...testcontainers-v4.5.0) (2024-05-25) ### Features * **core:** Private registry ([#566](#566)) ([59fbcfa](59fbcfa)) ### Bug Fixes * added types to exec & tc_properties_get_tc_host ([#561](#561)) ([9eabb79](9eabb79)) * on windows, DockerCompose.get_service_host returns an unusable "0.0.0.0" - adjust to 127.0.0.1 ([#457](#457)) ([2aa3d37](2aa3d37)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mbenabda
pushed a commit
to mbenabda/testcontainers-python
that referenced
this pull request
May 25, 2024
🤖 I have created a release *beep* *boop* --- ## [4.5.0](testcontainers/testcontainers-python@testcontainers-v4.4.1...testcontainers-v4.5.0) (2024-05-25) ### Features * **core:** Private registry ([testcontainers#566](testcontainers#566)) ([59fbcfa](testcontainers@59fbcfa)) ### Bug Fixes * added types to exec & tc_properties_get_tc_host ([testcontainers#561](testcontainers#561)) ([9eabb79](testcontainers@9eabb79)) * on windows, DockerCompose.get_service_host returns an unusable "0.0.0.0" - adjust to 127.0.0.1 ([testcontainers#457](testcontainers#457)) ([2aa3d37](testcontainers@2aa3d37)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#557 - trying to solve this issue by adding types.