Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Add kwargs to image build #708

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Tranquility2
Copy link
Contributor

@Tranquility2 Tranquility2 commented Oct 1, 2024

Fix: #706, #614

Now when using kwargs in the Image API, the params are passed correctly into the build

with DockerImage(path=dir, tag="test", buildargs={"MY_ARG": "some_arg"}) as image:

Added relevant test + updated docstring to better reflect the usage

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ace2a7d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage        ?   84.77%           
=======================================
  Files           ?       12           
  Lines           ?      670           
  Branches        ?      105           
=======================================
  Hits            ?      568           
  Misses          ?       79           
  Partials        ?       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@black-snow
Copy link
Contributor

Can we perhaps add a hint to the docstring that kwargs will be passed down to docker-py? That would pretty much solve #614 for me.

@Tranquility2
Copy link
Contributor Author

Tranquility2 commented Oct 2, 2024

@black-snow Updated docstring as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Docker image build kwargs is not working
3 participants