Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compose): support for setting profiles #738

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

totallyzen
Copy link
Collaborator

@totallyzen totallyzen commented Nov 18, 2024

Change

Adds profiles support for docker compose.

Context

I've had to use a workaround in a company project for compose profiles leading to multiple compose profile files.
This should help by supporting profiles in compose which is a very handy feature when your service has some variety of ways to run (contextual, environmental, etc)

Without this, it's still possible to run profiles buy setting the COMPOSE_PROFILES env variable, but this is certainly cleaner and easier on test writing.

Docker Docs

https://docs.docker.com/compose/how-tos/profiles/#assigning-profiles-to-services

Copy link
Member

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderankin alexanderankin merged commit 3e00e71 into main Nov 26, 2024
8 checks passed
@alexanderankin alexanderankin deleted the feat/profiles-in-compose branch November 26, 2024 19:21
alexanderankin pushed a commit that referenced this pull request Dec 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.9.0](testcontainers-v4.8.2...testcontainers-v4.9.0)
(2024-11-26)


### Features

* **compose:** support for setting profiles
([#738](#738))
([3e00e71](3e00e71))
* **core:** Support working with env files
([#737](#737))
([932ee30](932ee30))


### Bug Fixes

* allow running all tests
([#721](#721))
([f958cf9](f958cf9))
* **core:** Avoid hanging upon bad docker host connection
([#742](#742))
([4ced198](4ced198))
* **core:** running testcontainer inside container
([#714](#714))
([85a6666](85a6666))
* **generic:** Also catch URLError waiting for ServerContainer
([#743](#743))
([24e354f](24e354f))
* update wait_for_logs to not throw on 'created', and an optimization
([#719](#719))
([271ca9a](271ca9a))
* Vault health check
([#734](#734))
([79434d6](79434d6))


### Documentation

* Documentation fix for ServerContainer
([#671](#671))
([0303d47](0303d47))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants