Use Ruby 3.3.0-rc1 to fix mysql_ar_rspec #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby < 3.3.0 the default `timeout` gem version is `0.3.1`. `ActiveRecord >= 7.1` requires `timeout >= 0.4.0`. This causes a problem with inline gemfiles because `rubygems` loads `timeout 0.3.1` then `ActiveRecord` tries to require `timeout 0.4.1` but timeout is already loaded and we end up with this error: ``` runtime.rb:304:in `check_for_activated_spec!': You have already activated timeout 0.3.1, but your Gemfile requires timeout 0.4.1. Since timeout is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports timeout as a default gem. (Gem::LoadError) ``` Ruby 3.3.0 bumps the [default timeout version to 0.4.0](https://stdgems.org/default_gems.json) though so we can use Ruby 3.3.0 to fix ci. Locally, we need to wait for a new `rubygems` version that installs `timeout` to `>= 0.4.0` by default _or_ run `gem install --default timeout -v 0.4.1`.
This was referenced Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby < 3.3.0 the default
timeoutgem version is0.3.1.ActiveRecord >= 7.1requirestimeout >= 0.4.0. This causes a problem with inline gemfiles becauserubygemsloadstimeout 0.3.1thenActiveRecordtries to requiretimeout 0.4.1,but timeout is already loaded and we end up with this error:Ruby 3.3.0 bumps the default timeout version to 0.4.0 though, so we can use Ruby 3.3.0 to fix ci.
Locally, we need to wait for a new
rubygemsversion that installstimeoutto>= 0.4.0by default or rungem install --default timeout -v 0.4.1.