Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR options #30

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Add PR options #30

merged 4 commits into from
Sep 27, 2024

Conversation

yassine-cc
Copy link
Collaborator

No description provided.

@yassine-cc yassine-cc marked this pull request as draft September 27, 2024 12:47
@yassine-cc yassine-cc force-pushed the yassine/add-pr-options branch from d89510b to 299b428 Compare September 27, 2024 12:52
@yassine-cc yassine-cc force-pushed the yassine/add-pr-options branch 3 times, most recently from 6eeb51e to 1808615 Compare September 27, 2024 19:59
@yassine-cc yassine-cc marked this pull request as ready for review September 27, 2024 20:28
ianjennings
ianjennings requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@ianjennings ianjennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into sensible defaults so all fields are not required.

  • prBase can default to main
  • title, filename, and branch can all use the auto-generated stuff we were doing before.

src/config.js Outdated Show resolved Hide resolved
@ianjennings ianjennings merged commit aa3ae26 into main Sep 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjennings ianjennings ianjennings requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yassine-cc @ianjennings