Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): change the default schema URL for petstore #254

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ccoeurderoy
Copy link

Description

Since last week, the PetStore JSON schema has been removed from the OpenAPI spec (see this commit). It has been moved to the learn.openapis.org repo.

When running the camouflage server with the default config, we've got 404 HTTP errors :

Couldn't load OpenApi validation schema https://raw.githubusercontent.com/OAI/OpenAPI-Specification/main/examples/v3.0/petstore.json, because: Error downloading https://raw.githubusercontent.com/OAI/OpenAPI-Specification/main/examples/v3.0/petstore.json 
  • Change the OpenAPI validator URL to the learn OpenAPI repo

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Just run npm run start now and call the GET http://localhost:8080, there should be no more 404 errors.

Test Configuration:

  • OS: MacOS 15.0.1
  • Node version: v20.15.0
  • NPM Version: v10.7.0

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • This does not break any existing functionalities
  • Any dependent changes have been merged and published in downstream modules

@AdisRS
Copy link

AdisRS commented Nov 7, 2024

Could this be related?
Error on 2nd GET request

@ccoeurderoy
Copy link
Author

Could this be related?

Error on 2nd GET request

I think so, I got "socket hang up" errors too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants