Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit CONTRIBUTING.md #2618

Open
wants to merge 2 commits into
base: 3.2
Choose a base branch
from
Open

Edit CONTRIBUTING.md #2618

wants to merge 2 commits into from

Conversation

corydalis10
Copy link

@corydalis10 corydalis10 commented Jan 16, 2025

Describe your changes

Changed CONTRIBUTING.md to be more natural! I've also fixed the invalid path.
Please review my PR and let me know what you think.

What is your pull request about?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs and the indentation is five spaces
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

@drwetter
Copy link
Collaborator

Hi @corydalis10 ,
Thanks. I appreciate any corrections.

However there are a few points:

  • Pull Request: Why uppercase?
  • participation: I´d rather leave this.

While we are at it:

  • Travis is not anymore in use. We use GIthub actions
  • contributions via email never happened, so that we can remove
  • Headline can be a verb as the file name "Contributing / participating"

Then: I am not a native speaker and the rules for English commas are sometimes not obvious to me. But why do you put a comma after the "for ," pull requested sounds not good, though google means it exists

@corydalis10
Copy link
Author

@drwetter
I've made all the changes you requested! Please review again.

Then: I am not a native speaker and the rules for English commas are sometimes not obvious to me. But why do you put a comma after the "for ," pull requested sounds not good, though google means it exists

This feels weird to me. But I'll leave it because it makes sense with or without the comma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants