Update webextension's packages and fix code for Node.js 16 (#96)

textlint · Nov 24, 2024 · ce2cefe · ce2cefe
1 parent 0ee1f51
commit ce2cefe
Show file tree

Hide file tree

Showing 6 changed files with 1,619 additions and 2,351 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [ 18, 20, 22 ]
+        node-version: [ 16, 18, 20, 22 ]
         os: [ ubuntu-latest, windows-latest ]
     steps:
       - name: checkout
@@ -22,5 +22,11 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - name: Install
         run: yarn install
+      - name: Build
+        run: yarn run build
+      - name: Build webextension (Chrome)
+        run: npm run dist chrome
+        if: matrix.node-version == 16
+        working-directory: packages/webextension
       - name: Test
         run: yarn test
diff --git a/packages/@textlint/script-compiler/package.json b/packages/@textlint/script-compiler/package.json
@@ -74,7 +74,7 @@
     "devDependencies": {
         "@types/mocha": "^10.0.1",
         "@types/node": "^18.13.0",
-        "@types/webpack": "^4.41.26",
+        "@types/webpack": "^5.28.5",
         "mocha": "^8.4.0",
         "prettier": "^2.3.0",
         "textlint-rule-no-dropping-the-ra": "^3.0.0",

diff --git a/packages/webextension/app/scripts/InstalledApp/pages/EditPage.tsx b/packages/webextension/app/scripts/InstalledApp/pages/EditPage.tsx
@@ -124,7 +124,7 @@ const useForm = (props: ScriptMetaProps) => {
                     } catch (error) {
                         return {
                             ...prevState,
-                            textlintrc: error
+                            textlintrc: error instanceof Error ? error : null
                         };
                     }
                 });

diff --git a/packages/webextension/package.json b/packages/webextension/package.json
@@ -14,12 +14,14 @@
         "@types/reach__router": "^1.3.6",
         "@types/react": "^17.0.0",
         "@types/react-dom": "^17.0.0",
-        "copy-webpack-plugin": "^7.0.0",
-        "css-loader": "^5.0.1",
+        "copy-webpack-plugin": "9.0.1",
+        "css-loader": "^6.11.0",
+        "path-browserify": "^1.0.1",
         "style-loader": "^1.2.1",
-        "ts-loader": "^8.0.14",
-        "webextension-toolbox": "^3.0.0",
-        "webpack": "^4.44.0",
+        "ts-loader": "^8.4.0",
+        "webextension-toolbox": "^4.0.3",
+        "webpack": "5.42.0",
+        "webpack-sources": "^2.3.0",
         "webpack-watched-glob-entries-plugin": "^2.1.9"
     },
     "dependencies": {

diff --git a/...bextension/webextension-toolbox-config.js → ...bextension/webextension-toolbox.config.js b/...bextension/webextension-toolbox-config.js → ...bextension/webextension-toolbox.config.js
@@ -7,6 +7,7 @@ module.exports = {
         // Add typescript loader. supports .ts and .tsx files as entry points
         config.resolve.extensions.push(".ts");
         config.resolve.extensions.push(".tsx");
+        config.resolve.fallback = { path: require.resolve("path-browserify") };
         config.entry = GlobEntriesPlugin.getEntries([
             path.resolve("app", "*.{js,mjs,jsx,ts,tsx}"),
             path.resolve("app", "?(scripts)/*.{js,mjs,jsx,ts,tsx}")