Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: peer dependencies in webextension #105

Merged
merged 9 commits into from
Dec 10, 2024
Merged

fix: peer dependencies in webextension #105

merged 9 commits into from
Dec 10, 2024
+41 −54

Conversation

massongit
Copy link
Contributor

@massongit massongit commented Dec 10, 2024 •
edited
Loading

I update the following packages:

  • webpack-sources
  • react-codemirror2

I add typescript.

Fix #101
I replace @reach/router to @gatsbyjs/reach-router.
FYI: reach/router#429 (comment)

@massongit massongit changed the title Update and add peer dependencies fix: peer dependencies Dec 10, 2024
@massongit massongit requested a review from azu December 10, 2024 23:26
@massongit massongit changed the title fix: peer dependencies fix: peer dependencies in webextension Dec 10, 2024
azu
azu approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azu azu merged commit 6862363 into textlint:master Dec 10, 2024
7 checks passed
@massongit massongit deleted the add_peer_9 branch December 10, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azu azu azu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webextension: Replace @reach/router
2 participants
@massongit @azu