Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webextension's packages and fix code for Linux and Node.js 18 and after #97

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [ 16, 18, 20, 22 ]
node-version: [ 18, 20, 22 ]
os: [ ubuntu-latest, windows-latest ]
steps:
- name: checkout
Expand All @@ -26,7 +26,7 @@ jobs:
run: yarn run build
- name: Build webextension (Chrome)
run: npm run dist chrome
if: matrix.node-version == 16
if: matrix.os == 'ubuntu-latest'
working-directory: packages/webextension
- name: Test
run: yarn test
14 changes: 7 additions & 7 deletions packages/webextension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"version": "0.17.0",
"description": "textlint editor",
"scripts": {
"dev": "webextension-toolbox dev",
"dist": "webextension-toolbox build",
"dev": "webextension-toolbox dev --config webextension-toolbox.config.js",
"dist": "webextension-toolbox build --config webextension-toolbox.config.js",
"update-version": "node tools/sync-version.js && git add ./app/manifest.json && git commit -m 'chore(webextension): update version'"
},
"devDependencies": {
Expand All @@ -14,15 +14,15 @@
"@types/reach__router": "^1.3.6",
"@types/react": "^17.0.0",
"@types/react-dom": "^17.0.0",
"copy-webpack-plugin": "9.0.1",
"copy-webpack-plugin": "^12.0.2",
"css-loader": "^6.11.0",
"path-browserify": "^1.0.1",
"style-loader": "^1.2.1",
"ts-loader": "^8.4.0",
"webextension-toolbox": "^4.0.3",
"webpack": "5.42.0",
"ts-loader": "^9.5.1",
"@webextension-toolbox/webextension-toolbox": "^7.1.1",
"webpack": "^5.90.0",
"webpack-sources": "^2.3.0",
"webpack-watched-glob-entries-plugin": "^2.1.9"
"webpack-watched-glob-entries-plugin": "^3.0.0"
},
"dependencies": {
"@adobe/react-spectrum": "3.4.0",
Expand Down
4 changes: 0 additions & 4 deletions packages/webextension/webextension-toolbox.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ module.exports = {
path.resolve("app", "*.{js,mjs,jsx,ts,tsx}"),
path.resolve("app", "?(scripts)/*.{js,mjs,jsx,ts,tsx}")
]);
config.module.rules.push({
test: /\.tsx?$/,
loader: "ts-loader"
});
config.module.rules.push({
test: /\.css$/i,
use: ["style-loader", "css-loader"]
Expand Down
Loading