Eb ar estimate next purchase date issue 11

[arandel1]

Description

• When a user checks a checkbox, Firebase updates with a new date in the dateNextPurchased field
• dateNextPurchased uses the calculateEstimate function that takes into consideration three arguments: previousEstimate, daysSinceLastPurchase, and totalPurchases to give the user a more tailored dateNextPurchased estimate.

Related Issue

closes 11

Acceptance Criteria

• When the user purchases an item, the item’s dateNextPurchased property is calculated using the calculateEstimate function and saved to the Firestore database
• dateNextPurchased is saved as a date, not a number
• A getDaysBetweenDates function is exported from utils/dates.js and imported into api/firebase.js
• This function takes two JavaScript Dates and return the number of days that have passed between them

Type of Changes

enhancement

Updates

Before

• When user adds grapefruit to their list, dateNextPurchased is populated with a date that is days selected when adding an item (soon, kind of soon, not soon).
• Example: grapefruit is added on September 14, and dateNextPurchased is set to September 28

After

• When user adds lemons to their list, dateNextPurchased is populated with a date that calculates the user's shopping habits. If the user adds the item and checks it off immediately, dateNextPurchased takes into account the user buying the item once and one day later, and how often the user purchases the item.

Testing Steps / QA Criteria

• Pull from eb-ar-estimate-next-purchase-date-issue-11 branch
• Add an item and check the dateNextPurchase and dateLastPurchase
• Check that item off the list and see the dateNextPurchase will be to the next day.

[github-actions]

Visit the preview URL for this PR (updated for commit 689220a):

https://tcl-76-smart-shopping-list--pr28-eb-ar-estimate-next-dg99jllp.web.app

_{(expires Mon, 23 Sep 2024 20:46:05 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 512b1a88be8ae05fd3e727b99332819df760271d}

[MarcosPerez16]

Did some testing and everything is working. I went ahead and added an item and all the date props in firebase are updating correctly. When I check the item, dateNextPurchased updates to the next day.

[sar-mko]

Looks good! Really liked how organized and clean the code was. I was able to add an item, check the item, and dataNextPurchased was saved to the next day in Firebase.

I was also able to mess around with the dates in Firebase (while also manually incrementing totalPurchases), and was able to see varying dates saved in dateNextPurchased based off what was saved to dateLastPurchased.

[mindyzwan]

nitpick ( non-blocking ): You can just pass in the item here now:

Suggested change

	updateItem(listPath, id, {
	...item,
	})
	updateItem(listPath, id, item)

[mindyzwan]

praise (non-blocking): Always love typo cleanups!

[mindyzwan]

nitpick ( non-blocking | if-minor ): Should probably cleanup this stray console :)

Suggested change

console;

[mindyzwan]

nitpick ( non-blocking): And stray comment here

Suggested change

// import { calculateEstimate } from '@the-collab-lab/shopping-list-utils';

[mindyzwan]

You made it through time land! 🎉 Way to persist!