fixes on test case for entry preds;

the-deep-nlp · Nov 21, 2023 · 1966df0 · 1966df0
1 parent c7a212d
commit 1966df0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/analysis_module/mockserver.py b/analysis_module/mockserver.py
@@ -17,7 +17,7 @@
 
 from core.models import NLPRequest
 from core_server.settings import ENDPOINT_NAME
-from .mock_templates import MOCK_ENTRY_CLASSIFICATION_FORMATTED, MOCK_GEOLOCATION
+from .mock_templates import MOCK_ENTRY_CLASSIFICATION, MOCK_ENTRY_CLASSIFICATION_FORMATTED, MOCK_GEOLOCATION
 from .utils import send_callback_url_request
 
 

diff --git a/analysis_module/tests/test_apis.py b/analysis_module/tests/test_apis.py
@@ -420,11 +420,11 @@ def test_prediction_valid_data(self, model_prediction_class):
         for item in predictions:
             assert "client_id" in item
             assert "model_preds" in item
-        assert NLPRequest.objects.filter(
+        assert not NLPRequest.objects.filter(
             client_id=self.CLIENT_ID,
             created_by=self.user,
             status=NLPRequest.RequestStatus.SUCCESS,
-        ).exists(), "NLP request should be created with success status"
+        ).exists(), "No nlp request should be created"
 
     @patch("analysis_module.views.predictions.ModelTagsPrediction")
     def test_prediction_mock(self, model_prediction_class):

diff --git a/analysis_module/views/predictions.py b/analysis_module/views/predictions.py
@@ -7,7 +7,7 @@
 from core_server.settings import IS_MOCKSERVER
 from core.models import NLPRequest
 from analysis_module.serializers import TagsMappingRequestSerializer, PredictionRequestSerializer
-from analysis_module.mockserver import MOCK_ENTRY_CLASSIFICATION_FORMATTED
+from analysis_module.mockserver import MOCK_ENTRY_CLASSIFICATION
 from nlp_scripts.model_prediction.tags_mapping import AF2NLPMapping
 from nlp_scripts.model_prediction.model_prediction import ModelTagsPrediction
 from nlp_scripts.model_prediction.utils import get_vf_list
@@ -60,7 +60,7 @@ def entry_classification(request: Request):
     serializer = PredictionRequestSerializer(data=request.data)
     serializer.is_valid(raise_exception=True)
     if serializer.validated_data.get("mock") or IS_MOCKSERVER:
-        return Response(MOCK_ENTRY_CLASSIFICATION_FORMATTED)
+        return Response(MOCK_ENTRY_CLASSIFICATION)
     entries = serializer.validated_data["entries"]
     if not entries:
         return Response({"classifications": []})