Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entry extraction clasification #36

Merged
merged 14 commits into from
Nov 21, 2023
Merged

entry extraction clasification #36

merged 14 commits into from
Nov 21, 2023

Conversation

aembryonic
Copy link
Collaborator

No description provided.

@aembryonic aembryonic force-pushed the extraction branch 2 times, most recently from 5060f50 to 90aedc1 Compare November 9, 2023 08:55
ranjan-stha
ranjan-stha reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@ranjan-stha ranjan-stha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, in core/models.py, the line 460 that has type defined, the max_length should be larger than 20, let's say 50.

analysis_module/mock_templates.py Outdated Show resolved Hide resolved
Mogady
Mogady approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@Mogady Mogady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aembryonic
Copy link
Collaborator Author

good for me

@ranjan-stha ranjan-stha merged commit 15aaaa2 into main Nov 21, 2023
4 checks passed
@ranjan-stha ranjan-stha deleted the extraction branch November 21, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranjan-stha ranjan-stha ranjan-stha approved these changes

@Mogady Mogady Mogady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aembryonic @Mogady @ranjan-stha