Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/assessment dashboard statistics #1341

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Jul 26, 2023

Changes

  • Assessment Dashboard registry statistices
    • total assessment count
    • total stakeholder count
    • collection technique count
    • multisector and single sector assessment

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 changed the base branch from develop to project/assessment-registry July 26, 2023 09:31
@sudan45 sudan45 marked this pull request as draft July 27, 2023 04:18
@sudan45 sudan45 force-pushed the feature/assessment-dashboard-statistics branch from f696909 to f83101d Compare August 10, 2023 10:35
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Few comments

deep/schema.py Show resolved Hide resolved
apps/assessment_registry/dashboard_schema.py Outdated Show resolved Hide resolved
apps/assessment_registry/dashboard_schema.py Outdated Show resolved Hide resolved
apps/assessment_registry/dashboard_schema.py Outdated Show resolved Hide resolved
apps/assessment_registry/dashboard_schema.py Outdated Show resolved Hide resolved
apps/assessment_registry/dashboard_schema.py Outdated Show resolved Hide resolved
apps/assessment_registry/dashboard_schema.py Outdated Show resolved Hide resolved
apps/assessment_registry/dashboard_schema.py Outdated Show resolved Hide resolved
apps/assessment_registry/dashboard_schema.py Outdated Show resolved Hide resolved
apps/project/schema.py Outdated Show resolved Hide resolved
apps/project/schema.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/assessment-dashboard-statistics branch from f83101d to df9fdb2 Compare August 14, 2023 05:04
@sudan45 sudan45 marked this pull request as ready for review August 14, 2023 05:05
@sudan45 sudan45 force-pushed the feature/assessment-dashboard-statistics branch 3 times, most recently from 5c1fc46 to 2436e22 Compare August 16, 2023 08:24
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sudan45 sudan45 marked this pull request as draft August 16, 2023 08:29
@sudan45 sudan45 force-pushed the feature/assessment-dashboard-statistics branch 2 times, most recently from 274c808 to 289d3b2 Compare August 16, 2023 09:04
@sudan45 sudan45 marked this pull request as ready for review August 16, 2023 10:46
@sudan45 sudan45 force-pushed the feature/assessment-dashboard-statistics branch 3 times, most recently from 5f2930f to 4f35932 Compare August 28, 2023 08:34
@sudan45 sudan45 assigned sudan45 and unassigned thenav56 Aug 28, 2023
- Add heirarchy level and child count for assessment registry issues.
- total assessment count
- total stakeholder count
- collection technique count
- multisector and single sector assessment
- filter with affected groups
- filter with location,family,frequency,coordination_type,assessment_type and focus
- schema added
- number of assessment according to geographical area
- assessment by all time implemented
- assessment per geographic area completed  and so on
- assessment_per_sector_and_geoarea implemented
- assessment_by_lead_organization implemented and so on
 -total assessment
 -total collection technique
 -total multisector assessment
 -total singlesector assessment
 -collection technique test cases implemented
- assessment per unit of reporting implemented
- assessment per sampling approach implemented
- assessment per proxmity  implemented
…ted ie

  -data collection techniques
  -sampling approach
  -proximity
  -unit of analysis
  -unit of reporting
- location key  changed into geo_id
- region key  is added in the query
- minor error fixes
- geo_id chages into geoid(objects)
 -Median Quality Score by Geographical Area
 -Median Quality score Over Time
 -Median Score for Each Quality Dimension
Dataloader for the Organization
    -Optimized the queryset
    -implemented unit tests
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/assessment-dashboard-statistics branch from 211a27b to b9ff5ab Compare December 15, 2023 08:32
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the project/assessment-registry branch 2 times, most recently from cd30166 to 4255ae7 Compare December 28, 2023 04:46
@thenav56
Copy link
Member

thenav56 commented Dec 29, 2023

Closing in favor of #1402
NOTE: All review comments are fixed or moved to the new PR.

@thenav56 thenav56 closed this Dec 29, 2023
@thenav56 thenav56 deleted the feature/assessment-dashboard-statistics branch December 29, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants