BTRIA-2353 - Fix for WPML Integration with Search Location #4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowing for search location
|
@andrasguseo is going to do some recon with WPML team for how to recreate consistently for the QA team |
Camwyn
previously approved these changes
Aug 21, 2024
|
@sdokus the linked ticket is still in triage and not in the Drac project - you should reach out to Emily to get it moved. Before merging in case we need to bump it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
BTRIA-2353
🗒️ Description
Grabbing the change from #4603 this will fix the issue where WPML was breaking the location search from Google Maps API. All that was missing was the list of element ids to be merged into the array returned from
translate_elements(). Credit goes to @dgwatkins !🎥 Artifacts
Uploading CleanShot 2024-08-09 at 16.32.39.mp4…
✔️ Checklist
npm run changelogto add changelog file(s).wpunitorintegrationtests.wpunitorintegrationtests.