Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deref JSON schemas #47

Merged
merged 4 commits into from
Apr 25, 2016
Merged

Deref JSON schemas #47

merged 4 commits into from
Apr 25, 2016

Conversation

automata
Copy link
Contributor

@automata automata commented Apr 19, 2016

A first stab on #27.

Some dereferenced schemas can be longer than expected but more informative without $ref's.

@automata
Copy link
Contributor Author

Before:

2016-04-18-223548_658x634_scrot

After:

2016-04-18-223709_658x687_scrot

@@ -1,4 +1,5 @@
path = require 'path'
deref = require 'json-schema-deref-sync'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the existing dependency tv4 for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reading tv4's API I didn't find a way to dereference schemas.

@automata automata force-pushed the deref-json-schemas branch from 5f1722b to ab0bb42 Compare April 25, 2016 20:45
@automata
Copy link
Contributor Author

@jonnor should we merge? IMHO the most valuable contribution is to be able to easily navigate through JSON schemas (using some browser plugin like JSONView):

2016-04-25-174345_798x753_scrot

@automata automata changed the title WIP: Deref JSON schemas Deref JSON schemas Apr 25, 2016
@jonnor jonnor merged commit 4b94835 into master Apr 25, 2016
@jonnor jonnor deleted the deref-json-schemas branch April 25, 2016 22:05
@jonnor
Copy link
Contributor

jonnor commented Apr 25, 2016

@automata sure, this is better than what we have now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants