Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article with only image #61

Merged
merged 2 commits into from
Jul 12, 2016
Merged

Article with only image #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34ab821
Add test for #60
bergie Jul 12, 2016
c36b2da
Handle article with only an image, fixes #60
bergie Jul 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,12 @@ module.exports = class Flatten
caption = null
title = null
src = null
if tag.children.length is 1 and tag.children[0].name is 'img' and tag.children[0].attribs?.src
results.push
type: 'image'
html: @tagToHtml tag.children[0]
src: @normalizeUrl tag.children[0].attribs.src
return results
for child in tag.children
if child.name is 'h1' and not title
title = ''
Expand Down
6 changes: 5 additions & 1 deletion spec/Flatten.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ describe 'Flatten', ->
path: 'foo/bar.html'
items: [
id: 'http://html5doctor.com/the-article-element/'
html: "<article><h1>Apple</h1><p>The <b>apple</b> is the pomaceous fruit of the apple tree...</p></article><article><h1>Red Delicious</h1><img src=\"http://www.theproducemom.com/wp-content/uploads/2012/01/red_delicious_jpg.jpg\"><p>These bright red apples are the most common found in many supermarkets...</p></article>"
html: "<article><h1>Apple</h1><p>The <b>apple</b> is the pomaceous fruit of the apple tree...</p></article><article><h1>Red Delicious</h1><img src=\"http://www.theproducemom.com/wp-content/uploads/2012/01/red_delicious_jpg.jpg\"><p>These bright red apples are the most common found in many supermarkets...</p></article><article><img src=\"https://s3-us-west-2.amazonaws.com/the-grid-img/p/904a32ea9f56b9e7bf1b500e5e2e2217a090b225.jpg\"></article>"
]

expected =
Expand All @@ -699,6 +699,10 @@ describe 'Flatten', ->
title: 'Red Delicious'
caption: 'These bright red apples are the most common found in many supermarkets...'
src: 'http://www.theproducemom.com/wp-content/uploads/2012/01/red_delicious_jpg.jpg'
,
type: 'image'
html: "<img src=\"https://s3-us-west-2.amazonaws.com/the-grid-img/p/904a32ea9f56b9e7bf1b500e5e2e2217a090b225.jpg\">"
src: 'https://s3-us-west-2.amazonaws.com/the-grid-img/p/904a32ea9f56b9e7bf1b500e5e2e2217a090b225.jpg'
]
]

Expand Down