feat: eleventy plugin #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arashagp
force-pushed
the
feat/eleventy-plugin
branch
from
c7a6d12 to
c26a3c8
Compare
arashagp
force-pushed
the
feat/eleventy-plugin
branch
from
c26a3c8 to
012915f
Compare
arashagp
force-pushed
the
feat/eleventy-plugin
branch
from
a096fa4 to
a39858b
Compare
njfamirm
requested changes
Jan 25, 2025
| @@ -30,11 +30,12 @@ if (!platformInfo.development) { | |||
|
|
|||
| const postCss = /* @__PURE__ */ postcss(postCssPlugins); | |||
|
|
|||
| export async function postcssBuild(): Promise<void> { | |||
| logger.logMethod?.('postcssBuild'); | |||
| export async function postcssBuild(options: {inputDir: string, outputDir: string}): Promise<void> { | |||
There was a problem hiding this comment.
use defined type
comepelte docs for all functions
| export async function postcssBuild(): Promise<void> { | ||
| logger.logMethod?.('postcssBuild'); | ||
| export async function postcssBuild(options: {inputDir: string, outputDir: string}): Promise<void> { | ||
| postCssPlugins[0] = /* @__PURE__ */ postcssImport({ root: options.inputDir }); |
| /** | ||
| * Options for the eleventyMinifyHtmlPlugin. | ||
| */ | ||
| type EleventyPostCssPluginOptions = { |
There was a problem hiding this comment.
تایپ ها باید بالای فایل تعریف بشن
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export function eleventyPostCssBuildPlugin(eleventyConfig: any, options: EleventyPostCssPluginOptions): void { | ||
| // TODO: better event handling to just copy for the first time |
| // eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access | ||
| eleventyConfig.addTransform('minifyHtml', minifyingHtml); | ||
| } | ||
|
|
There was a problem hiding this comment.
اینو کلا نفهمیدم چطوری اینطوری شده
| /** | ||
| * The mode for the service worker. | ||
| */ | ||
| mode: 'production' | 'development', |
There was a problem hiding this comment.
لازم نیست مود رو از خودش بپرسی
خودت مستقیم بگیر
همچنین مود development ما کلا حذف شده
هدف چی بوده؟
| export async function generateServiceWorker(options:{ | ||
| outputDir: string, | ||
| deploymentServiceWorkerContent: string, | ||
| nameOfServiceWorker: string, |
There was a problem hiding this comment.
service worker path for both outdir and name
| const serviceWorkerDest = 'dist/service-worker.js'; | ||
|
|
||
| export async function generateServiceWorker(): Promise<BuildResult | null> { | ||
| export async function generateServiceWorker(options:{ |
There was a problem hiding this comment.
این فایل خیلی مهمه
هر کار خاصی رو انجام میده باید بکشیم بیرون
اپشن هم خالیه
خواستی بری سراغش بپرس
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tasks
Code & Documentation:
Project Management & Tracking:
Deployment & Testing (If Applicable):