Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand key label on hover #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

hainsdominic
Copy link

@hainsdominic hainsdominic commented Feb 3, 2023

In #105, the user would like some indication of the full label of the key without having to check the source code.

I implemented the hover for the label component, so when a user hovers on a label, it shows the full label not cropped.
This won't change the behaviour of labels that are not cropped.

Hovering on the RGB control keys display the full label. Selecting the key brings the full label to the foreground.
Selecting without hovering over the label does not show the full label.

Let me know what you think

Some screenshots to illustrate:

Screen Shot 2023-02-03 at 1 14 59 PM

Screen Shot 2023-02-03 at 1 15 07 PM

Screen Shot 2023-02-03 at 1 15 14 PM

@hainsdominic
Copy link
Author

@wilba can you take a look please 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant