Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of confirmation dialog for button events #212

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Cipulot
Copy link
Contributor

@Cipulot Cipulot commented Dec 6, 2023

This commit aims to provide a confirmation dialog in the browser when clicking on a button in Custom UI
This helps in cases the button is bound to some actions at the keyboard level that might cause data losses or resets.

The addition of the dialog box prevents the execution of the functions unless a confirmation is given.
The action name shown in the dialog text is dynamic and takes the name associated with the button.

Here's an example:
Screenshot 2023-12-06 at 1 19 21 AM

@Cipulot
Copy link
Contributor Author

Cipulot commented Jul 17, 2024

Implemented a toggle that enables this feature or leaves it disabled:
Screenshot 2024-07-17 at 1 23 45 PM

The default value has been set to TRUE.

@Cipulot
Copy link
Contributor Author

Cipulot commented Jul 26, 2024

This PR is on hold.
It was deemed more in line with the UI/UX of the app that having a dialog that follows the VIA app UI elements is more in line with the experience, instead of using a browser-based UI. As a reminder, the current dialog is provided by the browser tools and not by a dedicated render from the app.

The target is to have a dialog similar to the one that is presented when enabling the design tab for the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant