Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD NEW KEYBOARD AT2 #2344

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

ADD NEW KEYBOARD AT2 #2344

wants to merge 12 commits into from

Conversation

anubhavd7
Copy link

Description

QMK Pull Request

VIA Keymap Pull Request

Checklist

  • [ x] The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • [ x] VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • [x ] The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • [x ] I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • [x ] I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • [x ] I have tested this keyboard definition using VIA's "Design" tab.
  • [x ] I have tested this keyboard definition with firmware on a device.
  • [ x] I have assigned alpha keys and modifier keys with the correct colors.
  • [ x] The Vendor ID is not 0xFEED

@Cipulot Cipulot added the invalid This doesn't seem right label Oct 8, 2024
@Cipulot
Copy link
Collaborator

Cipulot commented Oct 8, 2024

Missing info all over the place on this one. Invalid until addressed by PR opener

@anubhavd7
Copy link
Author

please check it now sir

@Cipulot
Copy link
Collaborator

Cipulot commented Dec 15, 2024

still invalid, for some reason your PR adds an empty file as you can see in the files change list. That needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants