Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kb38 keyboard #2390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add kb38 keyboard #2390

wants to merge 1 commit into from

Conversation

DOIO2022
Copy link
Contributor

Description

Add kb38 keyboard

QMK Pull Request

qmk/qmk_firmware#23943
qmk/qmk_firmware#23461
qmk/qmk_firmware#21704
qmk/qmk_firmware#21268
qmk/qmk_firmware#19650

VIA Keymap Pull Request

the-via/qmk_userspace_via#11

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Dec 18, 2024

@DOIO2022 the json file name should be changed to kb38.json instead of kb38-01.json.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants