Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vector macropad json file #2391

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

daviddoan
Copy link
Contributor

Description

Adding json for vector macropad.

QMK Pull Request

qmk/qmk_firmware#24487

VIA Keymap Pull Request

the-via/qmk_userspace_via#13

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Dec 16, 2024

Still have errors in the build. Move your json to the V3 folder, not the src/ folder.

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Dec 18, 2024
@daviddoan
Copy link
Contributor Author

doh-homer-simpson

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants