Asciivideo #76
Open
Asciivideo #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ffmpeg claims to be cross-platform, so in theory it should work on Windows as well, but we'll have it tested just to be on the safe side. What is the suggested testing procedure, by the way? |
|
|
||
| def vid2frames(vid): | ||
| call(["rm", "-r", "/tmp/vid/"]) # Cleanup | ||
| call(["mkdir", "/tmp/vid/"]) # Fuck windows. Hey, MS, nobody cares about you! At least I don't, but my opinion counts as everybody, right? right? |
There was a problem hiding this comment.
This is almost certainly going to break on Windows, but I think I see a (simple) way to fix it. Stay tuned.
There was a problem hiding this comment.
Fortunately python has ways to handle file system operations.
| # Thanks to Steven Kay for img2ascii. | ||
|
|
||
|
|
||
| import Image |
There was a problem hiding this comment.
Wait. What library is this? ImageMagick?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request because @jgonggrijp asked me to.
Some things to think about though:
It does pull in ffmpeg as a depend, making it linux/OS X only (?)
There might be a framerate issue on some computers. I forget if I fixed it or not :/