-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushing blueprints of a new setup script #80
Open
lramati
wants to merge
29
commits into
the-xkcd-community:master
Choose a base branch
from
lramati:setup-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s 2 things: 1.) extend_user_env_posix writes to ~/.bashrc, not ~/.profile. It's more widly used and doesn't require a new login, just a new virtual terminal. 2.) extend_user_env_posix will check if it needs to write to ~/.bashrc, and only write if ~/.bashrc doesn't include an export statment for the current directory.
… funcs) to make rewriting the code simpler
… code to select run mode
…asnt 100% on some of the function calls
…install, and move, their parameters, and how i think they should function. other people should now have enough to contribute to the code, although i do realize im probably missing quite a bit.
…ctions. also wrote get_dir() and rewrote get_rsp_src_dir to use it
added a comment explaining what that mysterious import is
…Also capitalize docstring.
…was a stupid idea and killed it.
… supposed to do. Also, more ideas!
In light of commits e09da6e and fcc3e90 I have decided that going through all the issues and IRC logs and writing a clear document explaining what everything is supposed to do should be a priority. (Also after writing 10 commits in the last 2 days, I'm tired of git lumping them in with commits from july) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 files:
This push request is just so that other people can be aware of my work and help out with it.
I ask that this pull request not be merged until setup2.py is complete, but that instead, people push their work to my branch so that it will get added to this pull request and that when we finally merge this it will replace the old script with the new one.
Additionally, if anything is unclear, just leave a comment or include me on an issue and I'll try to clear it up.