Preventing Leakage of the RemotingSession

[sancheolz]

If the client process crashes, then checking idle sessions will not be able to close the session, because the _rawMessageTransport.SendMessage call will throw an exception.

[yallie]

Merging.

[yallie]

Thanks for the PR!
Hmm, looks like test cleanup fails for some reason.

[sancheolz]

Yes, it was introduced after updating WatsonTCP to 6.05. WatsonTcpServer trows TaskCanceledException in Dispose().

 [Test Class Cleanup Failure (CoreRemoting.Tests.SessionTests)]: System.AggregateException : One or more errors occurred. (A task was canceled.)
---- System.Threading.Tasks.TaskCanceledException : A task was canceled.
  Stack Trace:
     at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at WatsonTcp.WatsonTcpServer.Dispose(Boolean disposing)
   at WatsonTcp.WatsonTcpServer.Dispose()
   at CoreRemoting.Channels.Tcp.TcpServerChannel.Dispose() in /home/runner/work/CoreRemoting/CoreRemoting/CoreRemoting/Channels/Tcp/TcpServerChannel.cs:line 101
   at CoreRemoting.RemotingServer.Dispose() in /home/runner/work/CoreRemoting/CoreRemoting/CoreRemoting/RemotingServer.cs:line 208
   at CoreRemoting.Tests.ServerFixture.Dispose() in /home/runner/work/CoreRemoting/CoreRemoting/CoreRemoting.Tests/ServerFixture.cs:line 68

[sancheolz]

This test fails starting from 6.0 version of WatsonTCP:

var server = new WatsonTcpServer("127.0.0.1", 9000);
server.Events.MessageReceived += (_, _) => { Console.WriteLine("srecv"); };
server.Start();
var client = new WatsonTcpClient("127.0.0.1", 9000);
client.Events.MessageReceived += (_, _) => { Console.WriteLine("crecv"); };
client.Connect();
Task.Run(() => { client.SendAsync("aaa"); });
server.Dispose();

Reported dotnet/WatsonTcp#303

[yallie]

This test fails starting from 6.0 version of WatsonTCP:

Hmm, sometimes this code sample throws another exception:

An item with the same key has already been added

I've filed another issue about it — dotnet/WatsonTcp#304