Skip to content

Commit

Permalink
Merge pull request desktop#19735 from desktop/remove-pr-badge-status-…
Browse files Browse the repository at this point in the history
…tooltip

Remove status tooltip
  • Loading branch information
tidy-dev authored Dec 19, 2024
2 parents b8bc5b8 + 9e89be6 commit 47666e1
Showing 1 changed file with 1 addition and 23 deletions.
24 changes: 1 addition & 23 deletions app/src/ui/branches/ci-status.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@ import classNames from 'classnames'
import { GitHubRepository } from '../../models/github-repository'
import { DisposableLike } from 'event-kit'
import { Dispatcher } from '../dispatcher'
import {
ICombinedRefCheck,
IRefCheck,
isSuccess,
} from '../../lib/ci-checks/ci-checks'
import { ICombinedRefCheck, IRefCheck } from '../../lib/ci-checks/ci-checks'
import { IAPIWorkflowJobStep } from '../../lib/api'

interface ICIStatusProps {
Expand Down Expand Up @@ -115,7 +111,6 @@ export class CIStatus extends React.PureComponent<
this.props.className
)}
symbol={getSymbolForCheck(check)}
title={getRefCheckSummary(check)}
/>
)
}
Expand Down Expand Up @@ -190,20 +185,3 @@ export function getClassNameForLogStep(logStep: IAPIWorkflowJobStep): string {
// Pending
return ''
}

/**
* Convert the combined check to an app-friendly string.
*/
export function getRefCheckSummary(check: ICombinedRefCheck): string {
if (check.checks.length === 1) {
const { name, description } = check.checks[0]
return `${name}: ${description}`
}

const successCount = check.checks.reduce(
(acc, cur) => acc + (isSuccess(cur) ? 1 : 0),
0
)

return `${successCount}/${check.checks.length} checks OK`
}

0 comments on commit 47666e1

Please sign in to comment.