Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Polish translation #70

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

tojatomasz
Copy link
Contributor

@tojatomasz tojatomasz commented Dec 22, 2023

the "songs" text on the Stats page is not getting translated to "Piosenki"
it works on other languages (tested DE and FR)
idk why :/

everything else is working atm

image

@theRealPadster
Copy link
Owner

Hmm, that is a very interesting issue. It seems to be using the english fallback for stats.songWithCount for Polish for some reason, like it's not detecting the _one and _other versions. It works if you manually load those strings.
image

@theRealPadster
Copy link
Owner

@tojatomasz
Does this make any sense to you? i18next/i18next#1851 (comment)
My guess is that Polish uses different pluralization keys than "one" and "other".

@theRealPadster
Copy link
Owner

Yes, that looks like it fixes it.
image

Could you add translations for the following keys? I'm not sure if it uses the "other" one but probably include it just in case.

"songWithCount_one": "{{count}} piosenka (one)",
"songWithCount_few": "{{count}} piosenek (few)",
"songWithCount_many": "{{count}} piosenek (many)",
"songWithCount_other": "{{count}} piosenek (other)",

src/locales/pl.json Outdated Show resolved Hide resolved
@theRealPadster theRealPadster added the i18n Translations label Jan 2, 2024
@tojatomasz tojatomasz force-pushed the polish-translation branch from 71a576e to 4c911a0 Compare April 9, 2024 15:20
@theRealPadster theRealPadster merged commit 17257b5 into theRealPadster:main Apr 9, 2024
2 checks passed
@tojatomasz tojatomasz deleted the polish-translation branch April 10, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants