-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show relativePath in the result for better readability #30
base: master
Are you sure you want to change the base?
Conversation
y? Full path is always better |
Mostly we know where we are running the WITH RELATIVE PATH (with 3 columns. I feel we can remove the time colume) ✦ ❯ gg status
./nomad-cluster new files 00:00:00
./microservices-demo 1 ahead, modifications 00:00:00
./endgame/istio no changes 00:00:00
./endgame/k8s-cluster no changes 00:00:00
./endgame/kube-prometheus no changes 00:00:00
./compose2nomad no changes 00:00:00
./consul-k8s-l7-obs-guide no changes 00:00:00
./contacts-ui new files 00:00:00 WITH FULL PATH ✦ ❯ gg status
"/Users/dinesh/projects/trials/devops/nomad-cluster": new files
"/Users/dinesh/projects/trials/devops/microservices-demo": 1 ahead, modifications
"/Users/dinesh/projects/trials/devops/endgame/istio": no changes
"/Users/dinesh/projects/trials/devops/endgame/k8s-cluster": no changes
"/Users/dinesh/projects/trials/devops/endgame/kube-prometheus": no changes
"/Users/dinesh/projects/trials/devops/compose2nomad": no changes
"/Users/dinesh/projects/trials/devops/consul-k8s-l7-obs-guide": no changes
"/Users/dinesh/projects/trials/devops/contacts-ui": new files Output of relativePath looks simple. So suggesting. Thoughts ? |
I agree it looks simple. I was thinking, for navigation purposes... absolute path is always better. In case they see a repo with changes and want to go to it. Yes it will work with relative path also but only if their dir hasn't changed. Presentation wise, I would go with relative path... but for navigation purposes.. absolute is better. Lets take a scenario. I have a nested structure like this.
If I run gg from where dir1 is, I would get relative paths to each of these. Suppose I go inside dir1. I can no longer use any of the paths shown in gg status unless I run from within again. |
Yes. time column is not needed |
@dineshba Can I close this? Do you still think relative path is needed? |
I still feel, few might prefer relative path to absolute path. If it is configurable using some env or flag, it should be good. |
Ok. Keep it configurable |
No description provided.