json_decode fixes #465
Closed
json_decode fixes #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Breaking the diff against shish/safe into smaller parts for easier reviewing)
staabm
reviewed
Nov 28, 2024
| @@ -33,10 +33,10 @@ | |||
| * @throws JsonException if the JSON cannot be decoded. | |||
| * @link http://www.php.net/manual/en/function.json-decode.php | |||
| */ | |||
| function json_decode(string $json, bool $assoc = false, int $depth = 512, int $flags = 0): mixed | |||
| function json_decode(string $json, bool $associative = false, int $depth = 512, int $flags = 0): mixed | |||
There was a problem hiding this comment.
I think we should not rename the parameter, because of named arguments and php-src uses the name $assoc
|
I will just merge https://github.com/thecodingmachine/safe/pull/451/files which is what I would expect. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Breaking the diff against shish/safe into smaller parts for easier reviewing)