make build.sh more accurately match what the github workflow does #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to do `composer install` for both the generator and the generated files, because phpcbf needs to be run from the output directory using the output-directory config files -- this PR makes it so that running `./.devcontainer/build.sh` should generate byte-identical output to the regen-bot
staabm
reviewed
Dec 2, 2024
| @@ -3,4 +3,6 @@ ARG DEBIAN_FRONTEND=noninteractive | |||
| ARG XDEBUG_MODE=coverage | |||
| RUN apt update -y && apt install -y git composer php-cli php-dom php-curl php-xdebug vim | |||
| WORKDIR /app | |||
| CMD cd /app/generator/doc && ./update.sh && cd /app/generator && composer install && php ./safe.php generate && composer cs-fix | |||
| CMD cd /app/generator/doc && ./update.sh && \ | |||
| cd /app && composer install && \ | |||
There was a problem hiding this comment.
Is this something we should de-duplicate using a composer script ?
There was a problem hiding this comment.
This is installing the things necessary for composer to run, then running it - I'm not sure it could be much more de-duplicated ^^;
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to do
composer installfor both the generator and the generated files, because phpcbf needs to be run from the output directory, using the output-directory config files -- this PR makes it so that running./.devcontainer/build.shshould generate byte-identical output to the regen-bot