feat: add TLS support for Redis #718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfcnunes
suggested changes
Dec 15, 2023
| @@ -20,6 +20,7 @@ const env = cleanEnv(process.env, { | |||
| REDIS_PORT: num({ default: 6379 }), | |||
There was a problem hiding this comment.
If TLS is enabled, should we change the default port to 6380 if there isn't one set explicitly?
Like:
TLS disabled => REDIS_PORT=env.REDIS_PORT or 6379
TLS enabled => REDIS_PORT=env.REDIS_PORT or 6380
| @@ -20,6 +20,7 @@ const env = cleanEnv(process.env, { | |||
| REDIS_PORT: num({ default: 6379 }), | |||
| REDIS_PASSWORD: str({ default: "" }), | |||
| REDIS_DB: num({ default: 0 }), | |||
| REDIS_SSL: bool({ default: false }), | |||
There was a problem hiding this comment.
Why use a "deprecated" term like SSL instead of TLS directly?
PS: Some projects use REDIS_PROTOCOL (here you are proposing REDIS_SSL) as a flag with 2 options: (redis, rediss) as in (redis://:<password>@<host>:<port>/<db>, rediss://:<password>@<host>:<port>/<db>).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #717
Based on https://github.com/redis/ioredis#tls-options