Add proxy options to templates_import module

[adamlazik1]

relates to theforeman/foreman_templates#191.

[evgeni]

You don't have to pass IDs around, our abstraction layer can resolve entities for you :)

I've proposed changes (untested) that should do exactly that, treat "http_proxy" as an entity, and look it up via the API if passed.

[evgeni]

the diff looks good to me!
thanks!

[adamlazik1]

Hey @evgeni , I tried the patch but it does not seem to work:

ansible-playbook -i ,localhost -c local -e foreman_username=admin -e foreman_password=changeme -e templates_import_http_proxy='https proxy' -e templates_import_http_proxy_policy=selected -e foreman_server_url=http://foreman-dev.example.com -e foreman_validate_certs=false test.yaml  --module-path='foreman-ansible-modules/plugins/modules'

PLAY [all] ***********************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************************************************************************
ok: [localhost]

TASK [Sync templates in from a git repo] *****************************************************************************************************************************************************************************************************
[WARNING]: You have configured a plain HTTP server URL. All communication will happen unencrypted.
fatal: [localhost]: FAILED! => {"changed": false, "error": {"message": "Couldn't find HttpProxy without an ID"}, "msg": "Error while performing import on templates: 422 Client Error: Unprocessable Content for url: http://foreman-dev.example.com/api/templates/import"}

PLAY RECAP ***********************************************************************************************************************************************************************************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0   

The http proxy id param did not get passed to the API. Any idea what could be the issue?

[adamlazik1]

Hey @evgeni , I tried the patch but it does not seem to work:

ansible-playbook -i ,localhost -c local -e foreman_username=admin -e foreman_password=changeme -e templates_import_http_proxy='https proxy' -e templates_import_http_proxy_policy=selected -e foreman_server_url=http://foreman-dev.example.com -e foreman_validate_certs=false test.yaml  --module-path='foreman-ansible-modules/plugins/modules'

PLAY [all] ***********************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************************************************************************
ok: [localhost]

TASK [Sync templates in from a git repo] *****************************************************************************************************************************************************************************************************
[WARNING]: You have configured a plain HTTP server URL. All communication will happen unencrypted.
fatal: [localhost]: FAILED! => {"changed": false, "error": {"message": "Couldn't find HttpProxy without an ID"}, "msg": "Error while performing import on templates: 422 Client Error: Unprocessable Content for url: http://foreman-dev.example.com/api/templates/import"}

PLAY RECAP ***********************************************************************************************************************************************************************************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0   

The http proxy id param did not get passed to the API. Any idea what could be the issue?

🤦 nevermind I forgot to update my test file. Yeah it works as intended so now I just wait for linked PR to get merged before I mark this ready for merge.

ansible-playbook -i ,localhost -c local -e foreman_username=admin -e foreman_password=changeme -e 'templates_import_http_proxy="https proxy"' -e templates_import_http_proxy_policy=selected -e foreman_server_url=http://foreman-dev.example.com -e foreman_validate_certs=false test.yaml  --module-path='foreman-ansible-modules/plugins/modules'

PLAY [all] ***********************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************************************************************************
ok: [localhost]

TASK [Sync templates in from a git repo] *****************************************************************************************************************************************************************************************************
[WARNING]: You have configured a plain HTTP server URL. All communication will happen unencrypted.
changed: [localhost]

PLAY RECAP ***********************************************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

[evgeni]

🤦 nevermind I forgot to update my test file. Yeah it works as intended so now I just wait for linked PR to get merged before I mark this ready for merge.

Phew. Your PR to templates looks correct, and the same lookup works in many other places, so it would be very weird if it wouldn't work here.