Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for basic use of msync when needing to make updates #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Nov 2, 2020

No description provided.

README.md Outdated
bundle exec msync update --noop
```

This will clone all modules into `modules/` and apply any pending updates. Changes can then be inspected and Pull Request's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will clone all modules into `modules/` and apply any pending updates. Changes can then be inspected and Pull Request's
This will clone all modules into `modules/` and apply any pending updates. Changes can then be inspected and Pull Requests

@wbclark
Copy link
Contributor

wbclark commented Nov 2, 2020

Should we also provide instructions for using msync update --pr ? Is that part of the typical workflow with this tool?

@ekohl
Copy link
Member

ekohl commented Nov 2, 2020

Should we also provide instructions for using msync update --pr ? Is that part of the typical workflow with this tool?

I personally never used it. Mostly because I got used to doing it manual before modulesync could do that. Only with ce29c2c (just merged) we updated to a version that supports the option.

@ehelms
Copy link
Member Author

ehelms commented Nov 2, 2020

I never used it because it always did things from the main repository and not from the my fork, which I prefer if I am the one opening PRs to make it cleaner and prevent branch bloat.

@ekohl
Copy link
Member

ekohl commented Nov 3, 2020

I never used it because it always did things from the main repository and not from the my fork, which I prefer if I am the one opening PRs to make it cleaner and prevent branch bloat.

I didn't mention it, but that is indeed also something I thought about. I also like to review any changes before I submit the PR. Then I create PRs in a shell loop using hub.

Does it also make sense to mention --offline and -f flags?

@ehelms
Copy link
Member Author

ehelms commented Nov 3, 2020

Does it also make sense to mention --offline and -f flags?

If you can tell me the workflow and use case I will include it. My one use of --offline led to ending up with a confused state of my modules.

@ekohl
Copy link
Member

ekohl commented Nov 3, 2020

What I often do is use --noop to set up the branch structure. I notice a mistake, change the templates, run it with --offline to avoid all git operations. If I just want to change a single module, I use -f pulp for example (note pulp also matches pulpcore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants