Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37942 - Adding Ansible Check Mode to Ansible Job Templates #742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bnerickson
Copy link

@bnerickson bnerickson commented Oct 22, 2024

Overview of Changes

This PR intends to add the Ansible Check Mode (identified with the --check argument to ansible-runner) to Ansible Job Templates via a checkbox option. The follow-up after all the subsequent PRs are submitted/approved (hammer cli support for instance) is to add Ansible Diff Mode support in a similar manner. See below screenshot:

screenshot

Implementation Considerations

Foreman already offers the ability for users to run Ansible Config Commands (Running Ansible Roles on a host) with check mode enabled by setting the host's host parameter ansible_roles_check_mode to True. This is left in-place as-is. However, that implementation does not allow users to run Ansible Playbook jobs or any other custom remote execution jobs in Ansible Check Mode. Nor is setting a host parameter as flexible as setting an entire Job Template to use Ansible Check Mode.

I have a few questions/concerns:

  1. It's sort of kludgy, but I've added a separate "job_check_mode" variable passed to the smart_proxy_ansible plugin instead of using the existing "check_mode" variable. My reason for doing this is that the latter is used when setting the ansible_roles_check_mode host parameter which is only intended for use when running an Ansible Roles job. Meanwhile, this PR is intended for use on any host that is the target of any job whose template uses the new Ansible Check Mode (identified by the "job_check_mode" variable). Another reason I split the functions in two is that I do not want to break the existing functionality. Because of this change, "check_mode" with the ansible_roles_check_mode parameter will not work for rex (remote execution) jobs. This obviously runs completely counter to what I'm trying to accomplish in this PR.
  2. For the db/migrate/20241022000000_add_ansible_check_mode_to_templates.rb file, I arbitrarily set the date string in the filename to 20241022000000, but is that supposed to be automatically generated somehow?

Testing Steps

  1. Add the changes in Fixes #37942 - Add job_check_mode to allow Ansible Check Mode in Job Templates smart_proxy_ansible#94 to your test environment.
  2. Add the changes in this PR to your test environment.
  3. Clone the "Ansible Roles - Ansible Default" Job Template.
  4. In the clone's "Ansible" tab, select the "Ansible Check Mode Enabled" checkbox and save the Job Template.
  5. On a host, schedule a Job and select the cloned Job Category and Job Template. Execute the job.

Checklists

  • I am familiar with the contributing guidelines.
  • I have added relevant tests for my changes.
  • I have updated the documentation accordingly.

Additional Notes

This PR is not dependent on any other changes. The follow PRs are dependent on this change:

@bnerickson bnerickson changed the title Adding Ansible Check Mode to Ansible Job Templates Fixes #37942 - Adding Ansible Check Mode to Ansible Job Templates Oct 22, 2024
@adamruzicka
Copy link
Contributor

Would it also make sense to have this on the job level?

@bnerickson
Copy link
Author

Would it also make sense to have this on the job level?

Agreed! It'd be great if this were also available on a job-based level. I might tackle that after job templates are working. I don't know where to start there yet.

@maximiliankolb
Copy link
Contributor

cc @Thorben-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants