Fixes #38195 - Hide http proxy setting when syncing through ssh #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Feb 7, 2025
adamlazik1
force-pushed
the
fix-sync-ui
branch
from
30dcd12 to
82f2a29
Compare
|
Mention in apidoc added. |
Currently, the HTTP proxy policy setting in ui is displayed at all times. However it only goes into effect when syncing through HTTP or HTTPS. SSH sync does not use the proxy, therefore the user shoudn't be able to see the proxy policy if a protocol different from HTTP(S) is specified in the repo url.
adamlazik1
force-pushed
the
fix-sync-ui
branch
from
4b441e7 to
c91e58c
Compare
adamruzicka
approved these changes
Feb 10, 2025
|
Thank you @adamlazik1 & @aneta-petrova ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the HTTP proxy policy setting in ui is displayed at all times. However it only goes into effect when syncing through HTTP or HTTPS. SSH sync does not use the proxy, therefore the user shoudn't be able to see the proxy policy if a protocol different from HTTP(S) is specified in the repo url.