Refs #37130 - Set the mode on the generated bootstrap RPM #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We cannot use an implicit file resource here because the file that is generated depends on build time results of the rpmbuild process. |
|
Tests are passing now that the puppet fix is available. |
wbclark
reviewed
Mar 12, 2024
|
Should we do the same for the SRPM for consistency? It's not needed during deployment, but we do publish it in pub and if it's not readable it's useless. |
ehelms
force-pushed
the
refs-37130-1
branch
2 times, most recently
from
e15b94c to
5197ba7
Compare
wbclark
reviewed
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@evgeni I should have tried harder to test it the first time.