Fixes #37325 - make postgres the container gateway default DB #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Apr 5, 2024
There was a problem hiding this comment.
As mentioned in theforeman/puppet-foreman_proxy#835 (review), I'd prefer to manage the DB there.
I do wonder about external DB support. AFAIK we don't currently support that on content proxies, but if we would then we'd need to account for it.
| @@ -280,6 +280,16 @@ | |||
| pulp_endpoint => "https://${servername}", | |||
| } | |||
| } | |||
| include postgresql::client | |||
| include postgresql::server | |||
| include postgresql::server::contrib | |||
There was a problem hiding this comment.
Do you need extensions from contrib?
There was a problem hiding this comment.
Perhaps not, need to check.
| @@ -280,6 +280,16 @@ | |||
| pulp_endpoint => "https://${servername}", | |||
| } | |||
| } | |||
| include postgresql::client | |||
|
Closing to put this work in foreman_proxy. (theforeman/puppet-foreman_proxy#835) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to instantiate the postgres database for the container gateway. The main PR is here: theforeman/puppet-foreman_proxy#835
I'm not totally sure if foreman_proxy_content is the proper spot to create the DB, but it seemed better than doing it in foreman_proxy and adding a postgres library requirement there.
I'm looking for general feedback on what things I might be missing between the two PRs since I don't work on Puppet modules often.