Set Apache parameters in ci to reflect the real deployment #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
more-realistic-test-env
branch
from
b931473 to
ee2379c
Compare
ehelms
approved these changes
Aug 16, 2024
The installer has these values set and this makes the test more representative of the real world.
ekohl
force-pushed
the
more-realistic-test-env
branch
from
ee2379c to
5f1a97d
Compare
ekohl
commented
Aug 16, 2024
| @@ -1,5 +1,13 @@ | |||
| --- | |||
| apache::default_mods: false | |||
| # This is normally set in the installer, but the bootstrap_rpm test needs it | |||
There was a problem hiding this comment.
I didn't want to fully dive into it to fix the tests. This is already close enough now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer has these values set and this makes the test more representative of the real world.