Update gems to support testing Puppet 8 #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Merged
In the switch from beaker-puppet to beaker_puppet_helpers this was removed. Now it uses a regular shell command to achieve the same.
|
It still evaluates the class, so it hits the raise. Even though the real class wouldn't be executed on Archlinux. |
ehelms
approved these changes
Oct 6, 2023
ehelms
approved these changes
Oct 6, 2023
ekohl
force-pushed
the
update-gems
branch
2 times, most recently
from
6a6a8ac to
f8f0303
Compare
ehelms
approved these changes
Oct 12, 2023
|
The unit test failure was already addressed in a gem update. Once I fix the Archlinux tests I'd expect that to pass. |
With the unless keyword argument on a describe block the content is still parsed by Ruby. This means some functions are still executed. It also ends up triggering the unsupported version exception on Archlinux because the collection is unrecognized, even though the test really isn't run. By using the real Ruby unless statement this is all avoided.
|
Hmm, still not so I think I need some other update. |
evgeni
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.