Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3.6_Update.md with findings #1194

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Update 3.6_Update.md with findings #1194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions _includes/manuals/1.19/3.6_upgrade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ number from the previous release or "stable" to `{{ page.version }}`:
deb http://deb.theforeman.org/ stretch {{ page.version }}
deb http://deb.theforeman.org/ plugins {{ page.version }}

Next upgrade all Foreman packages:
Next upgrade all Foreman packages.
During the upgrade it's suggested to update the /etc/foreman/database.yml to the package version. If you used foreman-installer to setup your existing Foreman instance, make sure not to upgrade this file with the version from the package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does one update the /etc/foreman/database.yml to the package version.?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt upgrade will ask you what to do with config files. This is very similar to running rpmconf on RH-based systems but apt will ask you during the upgrade.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say in general you probably don't want to replace this, but there can be relevant changes; like recommending the increasing the default pool size. Not sure how to phrase this though.


apt-get update
apt-get --only-upgrade install ruby\* foreman\*
Expand Down Expand Up @@ -126,7 +127,7 @@ You should compile i18n strings and precompile assets now:
##### Step 3 (A) - Database migration and cleanup

The database should be migrated already, but you can make sure by executing the
migration script again, it should produce no errors or output:
migration script again, it should produce no errors or output. If you used foreman-installer to setup your existing Foreman instance, you can skip this step and jump over to step 3(C):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason we included this section is just to make sure any errors during db migration are obvious - even if it means the user has to try to repeat the migration process after the installer does it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installer doesn't clear the cache and existing sessions so totally jumping over it isn't correct. Running migrations and seeding doesn't hurt so I wouldn't skip it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That must have been my unfamiliarity (is that a word ?) with the complete solution.
Since the earlier change in the apt install step will make sure the database engine underneath the hood is not changes, I would think those steps will also not cause any problems.
Then.. would it be better to :
a ) Remove this addition in step 3A all together
b ) Move those commands to after running the foreman-installer (in case the foreman-installer was used to setup...etc)
Please advise.


foreman-rake db:migrate
foreman-rake db:seed
Expand Down