This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
Use oauth session for user calls; support for throttling calls #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently, user calls like `per_shelf_reviews` fail for users without public profiles. This is because the client is not using the authenticated session.
superdosh
changed the title
superdosh
changed the title
* The Goodreads API TOS says to limit to no more than 1 call per second. * This simple decorator allows the requests (in single-threaded applications) to be throttled in accordance via setting an environmental variable.
* As a result of the changes that attempt to use the client session, the GoodreadsComment test that tries to create the user started failing since the GoodreadsComment class didn't preserve the client. * This simple fix just preserves the client to preserve existing functionality.
superdosh
force-pushed
the
request-auth-fix
branch
from
b42cbb2 to
e069b87
Compare
|
@thejessleigh I'm not really sure how to replicate the build fail, so not sure what I need to fix. Any ideas? |
|
Hi! I'm so sorry I didn't see this. For some reason I haven't been getting email notifications about this repository. I'm looking at this tonight and hope to have a new version released over the weekend. Thank you for your patience! |
|
Hi! I'm so sorry for the delay. I took some time off of open source stuff due to work and personal reasons. I hope to start working through backlog PRs this month. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is in this PR?
Select all that apply
Bugfix
New feature
Documentation improvements
Improved test coverage
Other: (Please specify)
Issue
This might address the issue here, though that was not my goal: #34
Abstract
Dependency updates
None
Good Citizenship
I could use some help thinking through the right way to test the oauth session user calls. I don't believe there is currently an authentication test. I tested for my own user after authorizing my app, so it works in that one case!
I have updated any relevant documentation
I have run the pre-commit hooks for this repository's designated code styles