feat(ga): sync ga data lambda #93
Conversation
| startDate, | ||
| endDate, |
There was a problem hiding this comment.
shall we need to check dates here? startDate <= endDate?
There was a problem hiding this comment.
invalid input would fail the GA4 api request
|
|
||
| export const getLocalDateString = (date: Date) => { | ||
| // return utc+8 date string in YYYY-MM-DD format | ||
| return date.toLocaleDateString("sv", { timeZone: "Asia/Taipei" }); |
There was a problem hiding this comment.
is this sv using a Swedish locale? maybe toISOString is better? does here require a UTC+8 timezone cutoff of each day?
> (new Date).toISOString().substring(0, 10)
'2023-11-14'There was a problem hiding this comment.
does here require a UTC+8 timezone cutoff of each day?
Yes, as GA4 timezone settings is UTC+8
| } | ||
| } | ||
| if (insertRows.length > 0) { | ||
| await knex(TABLE_NAME).insert(insertRows); |
There was a problem hiding this comment.
and do you have estimation of how many rows will be there each day? what's growth estimation of this table per month;
There was a problem hiding this comment.
and there's a way to upsert might be useful in the case, one line to handle all rows:
INSERT INTO table (...) VALUES (...)
ON CONFLICT (id)
DO UPDATE SET total_users=EXCLUDED.total_users ;There was a problem hiding this comment.
upsert way doesn't work here, because table article_ga4_data has an exclusion constraint which ON CONFLICT syntax doesn't support
There was a problem hiding this comment.
do you have estimation of how many rows will be there each day? what's growth estimation of this table per month;
roughly 6k rows a day
No description provided.