Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove unused columns from article and draft table #3802

Merged
merged 6 commits into from
Mar 1, 2024
Merged

feat: remove unused columns from article and draft table #3802

merged 6 commits into from
Mar 1, 2024

Conversation

gary02
Copy link
Contributor

@gary02 gary02 commented Feb 20, 2024 •
edited
Loading

  • remove unused fields from article and draft table
  • fix to move dependency on those fields

@gary02 gary02 requested a review from a team as a code owner February 20, 2024 07:36
@gary02 gary02 linked an issue Feb 20, 2024 that may be closed by this pull request
Deprecate content fields of article table #2952
Closed
4 tasks
@gary02 gary02 force-pushed the feat/remove-unused-fields-of-article-table branch from a0482de to c3750fc Compare February 28, 2024 08:39
@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.42%. Comparing base (66f2f2f) to head (660fbc6).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/queries/user/collection/articles.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3802      +/-   ##
===========================================
+ Coverage    58.37%   58.42%   +0.05%     
===========================================
  Files          888      888              
  Lines        17332    17351      +19     
  Branches      3168     3165       -3     
===========================================
+ Hits         10118    10138      +20     
+ Misses        6518     6517       -1     
  Partials       696      696

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gary02 gary02 force-pushed the feat/remove-unused-fields-of-article-table branch from 180c335 to 660fbc6 Compare February 29, 2024 09:11
@gary02 gary02 merged commit 54d0574 into develop Mar 1, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/remove-unused-fields-of-article-table branch March 1, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertu7 robertu7 robertu7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate content fields of article table
2 participants
@gary02 @robertu7